The Static Analysis tool Coverity added that these two smart pointers addr and localaddr are allocated using malloc, but the inside function of the smart pointers releases that memory through delete operator. The both variables instance nsAutoPtr<char>, having this the function that manages memory on deletion are: >> void >> assign(T* aNewPtr) >> { >> T* oldPtr = mRawPtr; >> >> if (aNewPtr && aNewPtr == oldPtr) { >> NS_RUNTIMEABORT("Logic flaw in the caller"); >> } >> >> mRawPtr = aNewPtr; >> delete oldPtr; >> } >> ~nsAutoPtr() >> { >> delete mRawPtr; >> } assign is called when we doing any assignment between nsAutoPtr<char> and nsAutoPtr<char> or char*. As i don't see where delete operator is overloaded to use our own allocator that would go through malloc i would convert the malloc function to new allocator.

Review commit: https://reviewboard.mozilla.org/r/31237/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/31237/

Comment on attachment 8709039 [details] MozReview Request: Bug 1240515 - change allocator for addr and localaddr from malloc to new, since the smart pointer that is used uses delete operator. r=dragana https://reviewboard.mozilla.org/r/31237/#review27997

this failed to apply: applying b4a96cbe991c patching file netwerk/system/linux/nsNotifyAddrListener_Linux.cpp Hunk #1 FAILED at 237 1 out of 1 hunks FAILED -- saving rejects to file netwerk/system/linux/nsNotifyAddrListener_Linux.cpp.rej patch failed to apply abort: fix up the merge and run hg transplant --continue

Comment on attachment 8709039 [details] MozReview Request: Bug 1240515 - change allocator for addr and localaddr from malloc to new, since the smart pointer that is used uses delete operator. r=dragana Review request updated; see interdiff: https://reviewboard.mozilla.org/r/31237/diff/1-2/